Re: [PATCH] KVM: s390: vsie: Return correct values for Invalid CRYCB format

[Pierre Morel]

On 26/04/2019 11:03, Christian Borntraeger wrote:
> On 26.04.19 11:01, David Hildenbrand wrote:
> > On 26.04.19 11:00, Pierre Morel wrote:
> > > Let's use the correct validity number.
> > >
> > > Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
> >
> >   LANG=c git show 55ded154b43
> > fatal: ambiguous argument '55ded154b43': unknown revision or path not in
> > the working tree.
> > Use '--' to separate paths from revisions, like this:
>
> I think this should be
> 56019f9aca2266edc7f304d91e4e772023b7aa14

Yes it is, sorry, forgot to adjust the hash

> > > Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>
> > > Reviewed-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> > > ---
> > >   arch/s390/kvm/vsie.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> > > index ac411e9..076090f 100644
> > > --- a/arch/s390/kvm/vsie.c
> > > +++ b/arch/s390/kvm/vsie.c
> > > @@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
> > >   end:
> > >   	switch (ret) {
> > >   	case -EINVAL:
> > > -		return set_validity_icpt(scb_s, 0x0020U);
> > > +		return set_validity_icpt(scb_s, 0x0022U);
> > >   	case -EFAULT:
> > >   		return set_validity_icpt(scb_s, 0x0035U);
> > >   	case -EACCES:


--
Pierre Morel
Linux/KVM/QEMU in BÃblingen - Germany