Re: [PATCH v2 RFC/RFT 1/5] ARM: dma-mapping: Add fallback normal page allocations

From: Nicolin Chen
Date: Fri Apr 26 2019 - 16:21:24 EST


On Wed, Apr 24, 2019 at 05:06:38PM +0200, Christoph Hellwig wrote:
> > + if (!dma_release_from_contiguous(dev, page, count))
> > + __free_pages(page, get_order(size));
>
> Same for dma_release_from_contiguous - drop the _from, pass the
> actual size, and handle the free_pages fallback.

What do you think of dma_free_contiguous() instead? I feel "free"
is a bit more commonly used (in dma-mapping.h) and it's shorter.

Thanks