Re: [PATCH v2 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes

From: Martin Blumenstingl
Date: Sat Apr 27 2019 - 16:03:50 EST


On Tue, Apr 23, 2019 at 11:03 AM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
>
> Activating DDR in the Amlogic mmc controller, among other things, will
> divide the output clock by 2. So by activating it with clock on, we are
> creating a glitch on the output.
>
> Instead, let's deal with DDR when the clock output is off, when setting
> the clock.
>
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
[boot-tested on Khadas VIM and no obvious regressions could be seen]
Tested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

thank you for fixing this issue from v1!