Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

From: Andy Shevchenko
Date: Mon Apr 29 2019 - 09:19:41 EST


On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote:
> On 28.04.19 17:21, Andy Shevchenko wrote:

> >> +#define SERIAL_RT2880_IOSIZE 0x100
> >
> > And why this is in the header file and not in corresponding C one?
>
> hmm, no particular reason, maybe just an old habit to put definitions
> into .h files ;-)
>
> I can move it to 8250_of.c if you like me to.

Please, do.

--
With Best Regards,
Andy Shevchenko