RE: [PATCH] usbip: vhci_hcd: Mark expected switch fall-through

[David Laight]

From: Gustavo A. R. Silva
> Sent: 29 April 2019 15:40
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
...
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 667d9c0ec905..000ab7225717 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -508,6 +508,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
>  		case USB_PORT_FEAT_U1_TIMEOUT:
>  			usbip_dbg_vhci_rh(
>  				" SetPortFeature: USB_PORT_FEAT_U1_TIMEOUT\n");
> +			/* Fall through */
>  		case USB_PORT_FEAT_U2_TIMEOUT:
>  			usbip_dbg_vhci_rh(
>  				" SetPortFeature: USB_PORT_FEAT_U2_TIMEOUT\n");

That doesn't look right, both debug messages seem to get printed.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)