Re: [PATCH v2 2/4] dt-bindings: memory: Add binding for NVIDIA Tegra30 External Memory Controller

From: Rob Herring
Date: Mon Apr 29 2019 - 18:05:47 EST


On Sun, Apr 14, 2019 at 11:20:07PM +0300, Dmitry Osipenko wrote:
> Add device-tree binding for NVIDIA Tegra30 External Memory Controller.
> The binding is based on the Tegra124 EMC binding since hardware is
> similar, although there are couple significant differences.

My comments on Tegra124 binding apply here.

>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
> .../memory-controllers/nvidia,tegra30-emc.txt | 257 ++++++++++++++++++
> 1 file changed, 257 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.txt