Re: [PATCH 3/4] perf cgroup: Add cgroup ID as a key of RB tree

From: Peter Zijlstra
Date: Tue Apr 30 2019 - 05:04:08 EST


On Mon, Apr 29, 2019 at 07:44:04AM -0700, kan.liang@xxxxxxxxxxxxxxx wrote:
> +static struct perf_event *
> +perf_event_groups_first_cgroup(struct perf_event_groups *groups,
> + int cpu, u64 cgrp_id)
> +{
> + struct perf_event *node_event = NULL, *match = NULL;
> + struct rb_node *node = groups->tree.rb_node;
> +
> + while (node) {
> + node_event = container_of(node, struct perf_event, group_node);
> +
> + if (cpu < node_event->cpu) {
> + node = node->rb_left;
> + } else if (cpu > node_event->cpu) {
> + node = node->rb_right;
> + } else {
> + if (cgrp_id_low(cgrp_id) < cgrp_id_low(node_event->cgrp_id))
> + node = node->rb_left;
> + else if (cgrp_id_low(cgrp_id) > cgrp_id_low(node_event->cgrp_id))
> + node = node->rb_right;
> + else {
> + match = node_event;
> + node = node->rb_left;
> + }
> + }
> + }
> + return match;
> +}

That's whitespace challenged.