Re: [PATCH v2 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

[Daniel Lezcano]

On 29/04/2019 11:51, elaine.zhang wrote:

[ ... ]

> pinctrl select to gpio mode when tsadc suspend and shutdown.
> 
> When suspend, tsadc is disabled, the otp_pin should revert to the
> default gpio state.
> 
>>
>>> Â ÂÂÂÂÂ return 0;
>>> Â }
>>> @@ -1383,7 +1413,8 @@ static int __maybe_unused
>>> rockchip_thermal_resume(struct device *dev)
>>> ÂÂÂÂÂ for (i = 0; i < thermal->chip->chn_num; i++)
>>> ÂÂÂÂÂÂÂÂÂ rockchip_thermal_toggle_sensor(&thermal->sensors[i], true);
>>> Â -ÂÂÂ pinctrl_pm_select_default_state(dev);
>>> +ÂÂÂ if (thermal->tshut_mode == TSHUT_MODE_GPIO)
>>> +ÂÂÂÂÂÂÂ pinctrl_select_state(thermal->pinctrl, thermal->otp_state);
>> And then
>> ÂÂÂÂpinctrl_select_state(thermal->pinctrl, thermal->pinctrl_state);
> 
> pinctrl select to otp mode when tsadc resume.

Ok, thanks for clarifying.

  -- Daniel



-- 
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog