Re: [PATCH] arm64: dts: imx8mq: Add a node for irqsteer

[Lucas Stach]

Am Dienstag, den 30.04.2019, 15:41 +0200 schrieb Guido GÃnther:
> Add a node for the irqsteer interrupt controller found on the iMX8MQ
> SoC.
> 
> Signed-off-by: Guido GÃnther <agx@xxxxxxxxxxx>
> ---
> Âarch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++++
> Â1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 2cc939cfbd75..ce0e137ec8ee 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -798,6 +798,27 @@
> Â			};
> Â		};
> Â
> +		bus@32c00000 { /* AIPS4 */
> +			compatible = "fsl,imx8mq-aips-bus", "simple-bus";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0x32c00000 0x32c00000 0x400000>;
> +
> +			irqsteer: interrupt-controller@32e2d000 {
> +				compatible = "fsl,imx8m-irqsteer",
> +					ÂÂÂÂÂ"fsl,imx-irqsteer";

This fits on a single line, right?

> +				reg = <0x32e2d000 0x1000>;
> +				interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> +				clock-names = "ipg";
> +				fsl,channel = <0>;
> +				fsl,num-irqs = <64>;
> +				interrupt-controller;
> +				interrupt-parent = <&gic>;

This is wrong, the irqsteer upstream IRQ is routed through the GPC like
all the other peripheral interrupts. You can just drop this property.

With this fixed:
Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>

Regards,
Lucas

> +				#interrupt-cells = <1>;
> +			};
> +		};
> +
> Â		gpu: gpu@38000000 {
> Â			compatible = "vivante,gc";
> Â			reg = <0x38000000 0x40000>;