Re: [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up

From: Christian Lamparter
Date: Tue Apr 30 2019 - 17:32:38 EST


On Sunday, April 28, 2019 5:08:22 PM CEST Jonathan Neuschäfer wrote:
> The property is spelled 'bias-pull-up', as documented in
> pinctrl-bindings.txt.
>

I also sent out a patch for that... back in 2017:

https://patchwork.ozlabs.org/patch/763151/

It's marked Accepted and Archived.

@rob ?

> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> ---
> .../devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
> index c2dbb3e8d840..4e90ddd77784 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
> @@ -42,7 +42,7 @@ information about e.g. the mux function.
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
>
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
> output-low, output-high.
>
> Non-empty subnodes must specify the 'pins' property.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
> index 991be0cd0948..84be0f2c6f3b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
> @@ -44,7 +44,7 @@ information about e.g. the mux function.
>
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength.
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength.
>
> Non-empty subnodes must specify the 'pins' property.
> Note that not all properties are valid for all pins.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
> index 7ed56a1b70fc..a7aaaa7db83b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
> @@ -42,7 +42,7 @@ information about e.g. the mux function.
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
>
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
> output-low, output-high.
>
> Non-empty subnodes must specify the 'pins' property.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
> index cdc4787e59d2..f095209848c8 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
> @@ -42,7 +42,7 @@ information about e.g. the mux function.
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
>
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
> output-low, output-high.
>
> Non-empty subnodes must specify the 'pins' property.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
> index c22e6c425d0b..004056506679 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
> @@ -41,7 +41,7 @@ information about e.g. the mux function.
>
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength.
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength.
>
> Non-empty subnodes must specify the 'pins' property.
> Note that not all properties are valid for all pins.
> --
> 2.20.1
>