Re: [PATCH v1] mmc: dt: add DT bindings for ls1028a eSDHC host controller

From: Li Yang
Date: Tue Apr 30 2019 - 19:12:32 EST


On Tue, Apr 30, 2019 at 12:16 AM Yinbo Zhu <yinbo.zhu@xxxxxxx> wrote:
>
> From: Yinbo Zhu <yinbo.zhu@xxxxxxx>

The patch title better to be "dt-bindings: mmc: ..."
>
> Add "fsl,ls1028a-esdhc" bindings for ls1028a eSDHC host controller
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@xxxxxxx>
> ---
> .../devicetree/bindings/mmc/fsl-esdhc.txt | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> index 99c5cf8..a7250b9 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> @@ -21,6 +21,7 @@ Required properties:
> "fsl,ls1043a-esdhc"
> "fsl,ls1046a-esdhc"
> "fsl,ls2080a-esdhc"
> + "fsl,ls1028a-esdhc"

Better to be alphabetical order.

> - clock-frequency : specifies eSDHC base clock frequency.
>
> Optional properties:
> --
> 1.7.1
>