Re: [RFC PATCH 5/5] net: dsa: add support for mv88e6250

From: Andrew Lunn
Date: Wed May 01 2019 - 16:29:21 EST


> +++ b/drivers/net/dsa/mv88e6xxx/global1.c
> @@ -205,6 +205,26 @@ int mv88e6352_g1_reset(struct mv88e6xxx_chip *chip)
> return mv88e6352_g1_wait_ppu_polling(chip);
> }
>
> +/* copy of mv88e6352_g1_reset, without tailcall of mv88e6352_g1_wait_ppu_polling. */

Nit:

No need to have this comment.

Otherwise

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew