Re: [PATCH] perf vendor events arm64: Add Cortex-A72 events

[Florian Fainelli]

On 4/11/19 6:01 AM, John Garry wrote:
> On 07/04/2019 22:34, Florian Fainelli wrote:
>> The Cortex-A72 supports all ARMv8 recommended events up to the
>> RC_ST_SPEC (0x91) event, create an appropriate JSON file for mapping
>> those events and update the mapfile.csv for matching the Cortex-A72 MIDR
>> to that file.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>> ---
>> Â.../arm64/arm/cortex-a72/core-imp-def.jsonÂÂÂ | 206 ++++++++++++++++++
>> Âtools/perf/pmu-events/arch/arm64/mapfile.csv | 1 +
>> Â2 files changed, 207 insertions(+)
>> Âcreate mode 100644
>> tools/perf/pmu-events/arch/arm64/arm/cortex-a72/core-imp-def.json
>>
>> diff --git
>> a/tools/perf/pmu-events/arch/arm64/arm/cortex-a72/core-imp-def.json
>> b/tools/perf/pmu-events/arch/arm64/arm/cortex-a72/core-imp-def.json
>> new file mode 100644
>> index 000000000000..eb82fc8529c6
>> --- /dev/null
>> +++ b/tools/perf/pmu-events/arch/arm64/arm/cortex-a72/core-imp-def.json
>> @@ -0,0 +1,206 @@
>> +[
>> +ÂÂÂ {
>> +ÂÂÂÂÂÂÂ "ArchStdEvent": "L1D_CACHE_RD",
>> +ÂÂÂ },
>> +ÂÂÂ {
>> +ÂÂÂÂÂÂÂ "ArchStdEvent": "L1D_CACHE_WR",
>> +ÂÂÂ },
>> +ÂÂÂ {
>> +ÂÂÂÂÂÂÂ "ArchStdEvent": "L1D_CACHE_REFILL_RD",
>> +ÂÂÂ },
>> +ÂÂÂ {
>> +ÂÂÂÂÂÂÂ "ArchStdEvent": "L1D_CACHE_REFILL_WR",
>> +ÂÂÂ },
>> +ÂÂÂ {
>> +ÂÂÂÂÂÂÂ "ArchStdEvent": "L1D_CACHE_REFILL_INNER",
> 
> I'm just checking the A72 TRM, and this does not seem to be included,
> that being event number 0x44.
> 
>> +ÂÂÂ },
>> +ÂÂÂ {
>> +ÂÂÂÂÂÂÂ "ArchStdEvent": "L1D_CACHE_REFILL_OUTER",
>> +ÂÂÂ },
> 
> Or this.
> 
>> +ÂÂÂ {
>> +ÂÂÂÂÂÂÂ "ArchStdEvent": "L1D_CACHE_WB_VICTIM",
>> +ÂÂÂ },
>> +ÂÂÂ {
> 
> Please check this.

Indeed, thanks!
-- 
Florian