Re: [PATCH 4.19 10/72] ieee802154: hwsim: propagate genlmsg_reply return code

[Pavel Machek]

On Thu 2019-05-02 17:20:32, Greg Kroah-Hartman wrote:
> [ Upstream commit 19b39a25388e71390e059906c979f87be4ef0c71 ]
> 
> genlmsg_reply can fail, so propagate its return code

> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
> index 624bff4d3636..f1ed1744801c 100644
> --- a/drivers/net/ieee802154/mac802154_hwsim.c
> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> @@ -332,7 +332,7 @@ static int hwsim_get_radio_nl(struct sk_buff *msg, struct genl_info *info)
>  			goto out_err;
>  		}
>  
> -		genlmsg_reply(skb, info);
> +		res = genlmsg_reply(skb, info);
>  		break;
>  	}

How does the bug manifest for the user and is it severe enough?

Should this free the skb when it is signalling an error?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature