Re: [PATCH v2 4/4] s390: fix clang -Wpointer-sign warnigns in boot code
From: Heiko Carstens
Date: Fri May 03 2019 - 11:18:26 EST
On Mon, Apr 15, 2019 at 10:35:54AM +0200, Arnd Bergmann wrote:
> The arch/s390/boot directory is built with its own set of compiler
> options that does not include -Wno-pointer-sign like the rest of
> the kernel does, this causes a lot of harmess but correct warnings
> when building with clang.
>
> For the atomics, we can add type casts to avoid the warnings, for
> everything else the easiest way is to slightly adapt the types
> to be more consistent.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> arch/s390/boot/ipl_parm.c | 2 +-
> arch/s390/include/asm/bitops.h | 12 ++++++------
> arch/s390/include/asm/ebcdic.h | 2 +-
> arch/s390/include/asm/lowcore.h | 2 +-
> drivers/s390/char/sclp.h | 4 ++--
> 5 files changed, 11 insertions(+), 11 deletions(-)
Applied, with typo fix and a simple coding style issue.
Thanks!