Re: [PATCH v3] x86: mm: Do not use set_{pud,pmd}_safe when splitting the large page

From: Singh, Brijesh
Date: Fri May 03 2019 - 11:29:00 EST


Hi Boris,

On 4/17/19 12:24 PM, Dave Hansen wrote:
...

>
> The comment here is missing one key point:
> kernel_physical_mapping_init() can only be used to populate non-present
> entries. It kinda infers that from "Create...", but I really think we
> need to be explicit.
>
> Anyway, it's better than it was, and it does fix a bug, so:
>
> Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxx>
>
> But please flesh out that comment if you do another version for some reason.
>

Can you please pick this patch? Or do you want me to resend it ?
It's fixing a bug seen in SEV guest.

-Brijesh