Re: [GIT PULL 19/22] intel_th: msu: Introduce buffer driver interface

From: Greg Kroah-Hartman
Date: Fri May 03 2019 - 12:19:58 EST

On Fri, May 03, 2019 at 11:44:52AM +0300, Alexander Shishkin wrote:
> Introduces a concept of buffer drivers, which is a mechanism for creating
> trace sinks that would receive trace data from MSC buffers and transfer it
> elsewhere.
> A buffer driver can implement its own window allocation/deallocation if
> it has to. It must provide a callback that's used to notify it when a
> window fills up, so that it can then start a DMA transaction from that
> window 'elsewhere'. This window remains in a 'locked' state and won't be
> used for storing new trace data until the buffer driver 'unlocks' it with
> a provided API call, at which point the window can be used again for
> storing trace data.
> This relies on a functional "last block" interrupt, so not all versions of
> Trace Hub can use this feature.
> Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> ---

Why is no one else reviewing any of these patches at all? Are you
relying on me to do that?

I'll stop here on this patch series, I've applied all but one before
this, but don't have the time to properly review this one, especially so
late before the merge window closes (really, my tree should be closed

Please fix up the 2 I responded to, and get other people to review these
patches _before_ you ask me to merge them. Having code with no other
reviewer at all is not good at all.


greg k-h