Re: [PATCH v6 3/3] dt-bindings: power: supply: Add bindings for Microchip UCS1002

[Andrey Smirnov]

On Fri, May 3, 2019 at 12:03 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On Fri, May 03, 2019 at 10:00:42AM -0700, Andrey Smirnov wrote:
> > Add bindings for Microchip UCS1002 Programmable USB Port Power
> > Controller with Charger Emulation.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> > Reviewed-by: Rob Herring <robh+dt@xxxxxxxxxx>
> > Cc: Enric Balletbo Serra <enric.balletbo@xxxxxxxxxxxxx>
> > Cc: Chris Healy <cphealy@xxxxxxxxx>
> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > Cc: Fabio Estevam <festevam@xxxxxxxxx>
> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Cc: Sebastian Reichel <sre@xxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: linux-pm@xxxxxxxxxxxxxxx
> > ---
> >  .../power/supply/microchip,ucs1002.txt        | 27 +++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt
> > new file mode 100644
> > index 000000000000..1d284ad816bf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt
> > @@ -0,0 +1,27 @@
> > +Microchip UCS1002 USB Port Power Controller
> > +
> > +Required properties:
> > +- compatible         : Should be "microchip,ucs1002";
> > +- reg                        : I2C slave address
> > +
> > +Optional properties:
> > +- interrupts         : A list of interrupts lines present (could be either
> > +                       corresponding to A_DET# pin, ALERT# pin, or both)
> > +- interrupt-names    : A list of interrupt names. Should contain (if
> > +                       present):
> > +                       - "a_det" for line connected to A_DET# pin
> > +                       - "alert" for line connected to ALERT# pin
> > +                       Both are expected to be IRQ_TYPE_EDGE_BOTH
> > +Example:
> > +
> > +&i2c3 {
> > +     charger@32 {
> > +             compatible = "microchip,ucs1002";
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_ucs1002_pins>;
> > +             reg = <0x32>;
> > +             interrupts-extended = <&gpio5 2 IRQ_TYPE_EDGE_BOTH>,
> > +                                   <&gpio3 21 IRQ_TYPE_EDGE_BOTH>;
>
> interrupts ?

Can't really use it here since it assumes single "interrupt-parent"
(we have gpio5 and gpio3 as parents above)

Thanks,
Andrey Smirnov