Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates
From: Joe Perches
Date: Fri May 03 2019 - 17:47:07 EST
On Fri, 2019-05-03 at 15:22 -0400, Mathieu Desnoyers wrote:
> ----- On May 3, 2019, at 2:53 PM, shuah shuah@xxxxxxxxxx wrote:
> > ERROR: need consistent spacing around '%' (ctx:WxV)
> > #227: FILE: tools/testing/selftests/rseq/rseq-x86.h:104:
> > + RSEQ_ASM_CMP_CPU_ID(cpu_id, RSEQ_CPU_ID_OFFSET(%[rseq_abi]), %l[error1])
> >
> > Will you be able to fix them and resend?
[]
> (CCing the che checkpatch maintainers)
>
> checkpatch appears to be wrong for these errors. I suspect it thinks those are
> '%' modulo operators (for which the style requires space before/after),
> but those are actually part of the asm input and goto target operands.
checkpatch doesn't really understand asm.
Ignore checkpatch when it's silly.