Re: [PATCH] signal: reorder struct sighand_struct

[Michal Hocko]

CCing Oleg.

On Fri 03-05-19 22:28:00, Alexey Dobriyan wrote:
[...]
> add/remove: 0/0 grow/shrink: 8/68 up/down: 49/-1147 (-1098)
[...]
> --- a/include/linux/sched/signal.h
> +++ b/include/linux/sched/signal.h
> @@ -15,10 +15,10 @@
>   */
>  
>  struct sighand_struct {
> -	refcount_t		count;
> -	struct k_sigaction	action[_NSIG];
>  	spinlock_t		siglock;
> +	refcount_t		count;
>  	wait_queue_head_t	signalfd_wqh;
> +	struct k_sigaction	action[_NSIG];
>  };

Is it possible that this would cause false sharing of the cache line
that would have performance implications now?

-- 
Michal Hocko
SUSE Labs