Re: [v2 PATCH] RISC-V: Add a PE/COFF compliant Image header.

From: Karsten Merker
Date: Sat May 04 2019 - 20:38:49 EST

On Wed, May 01, 2019 at 12:56:07PM -0700, Atish Patra wrote:

> Currently, last stage boot loaders such as U-Boot can accept only
> uImage which is an unnecessary additional step in automating boot flows.
> Add a PE/COFF compliant image header that boot loaders can parse and
> directly load kernel flat Image. The existing booting methods will continue
> to work as it is.
> Another goal of this header is to support EFI stub for RISC-V in future.
> EFI specification needs PE/COFF image header in the beginning of the kernel
> image in order to load it as an EFI application. In order to support
> EFI stub, code0 should be replaced with "MZ" magic string and res5(at
> offset 0x3c) should point to the rest of the PE/COFF header (which will
> be added during EFI support).
> Tested on both QEMU and HiFive Unleashed using OpenSBI + U-Boot + Linux.
> Signed-off-by: Atish Patra <atish.patra@xxxxxxx>

Looks good to me.

Reviewed-by: Karsten Merker <merker@xxxxxxxxxx>
Tested-by: Karsten Merker <merker@xxxxxxxxxx> (QEMU+OpenSBI+U-Boot)

Ich widerspreche hiermit ausdrÃcklich der Nutzung sowie der
Weitergabe meiner personenbezogenen Daten fÃr Zwecke der Werbung
sowie der Markt- oder Meinungsforschung.