Re: [PATCH] mptsas: fix undefined behaviour of a shift of an int by more than 31 places

From: James Bottomley
Date: Sat May 04 2019 - 23:35:14 EST


On Sat, 2019-05-04 at 17:40 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently the shift of int value 1 by more than 31 places can result
> in undefined behaviour. Fix this by making the 1 a ULL value before
> the shift operation.

Fusion SAS is pretty ancient. I thought the largest one ever produced
had four phys, so how did you produce the overflow?

James