Re: [PATCH RFC 3/6] ARM: qcom_defconfig: add display-related options

[Linus Walleij]

On Sun, May 5, 2019 at 3:04 PM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote:

> Add the CMA (Contiguous Memory Allocator) for the MSM DRM driver, the
> simple panel, and the TI LM3630A driver in order to support the display
> on the LG Nexus 5 (hammerhead) phone.
>
> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> The panel and backlight are currently compiled into the kernel, but will
> be moved to be modules once the display is fully working in a later
> verison of this patch series.

I don't see why we would want to do that, the FB console is
traditionally (x86) good to alwaÃs get up, as serial console
might not always be available. For example for people
who can't solder special cables but still want to boot a
custom ROM on their Nexus. So I'd say keep it like this.

Yours,
Linus Walleij