Re: [PATCH] platform/x86: pmc_atom: Add Lex 3I380D industrial PC to critclk_systems DMI table

[Andy Shevchenko]

On Mon, Apr 29, 2019 at 6:01 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> The Lex 3I380D industrial PC has 4 ethernet controllers on board
> which need pmc_plt_clk0 - 3 to function, add it to the critclk_systems
> DMI table, so that drivers/clk/x86/clk-pmc-atom.c will mark the clocks
> as CLK_CRITICAL and they will not get turned off.
>

Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
supposedly to go via CLK tree.

P.S. If you want it through PDx86, I need immutable branch / tag from CLK.

> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Reported-and-tested-by: Semyon Verchenko <semverchenko@xxxxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/platform/x86/pmc_atom.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index 3a635ea09b8a..2910845b7cdd 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -407,12 +407,21 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc)
>   */
>  static const struct dmi_system_id critclk_systems[] = {
>         {
> +               /* pmc_plt_clk0 is used for an external HSIC USB HUB */
>                 .ident = "MPL CEC1x",
>                 .matches = {
>                         DMI_MATCH(DMI_SYS_VENDOR, "MPL AG"),
>                         DMI_MATCH(DMI_PRODUCT_NAME, "CEC10 Family"),
>                 },
>         },
> +       {
> +               /* pmc_plt_clk0 - 3 are used for the 4 ethernet controllers */
> +               .ident = "Lex 3I380D",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "Lex BayTrail"),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "3I380D"),
> +               },
> +       },
>         { /*sentinel*/ }
>  };
>
> --
> 2.21.0
>


-- 
With Best Regards,
Andy Shevchenko