Re: [PATCH] ASoC: Intel: bytcr_rt5651.c: remove string buffers 'byt_rt5651_cpu_dai_name' and 'byt_rt5651_cpu_dai_name'

[Pierre-Louis Bossart]

On 5/6/19 10:40 AM, Hans de Goede wrote:
> Hi,
>
> On 05-05-19 09:51, Takashi Iwai wrote:
> > On Sat, 04 May 2019 17:16:52 +0200,
> > Nariman wrote:
> > > From: Jordy Ubink <jordyubink@xxxxxxxxxx>
> > >
> > > The snprintf calls filling byt_rt5651_cpu_dai_name / 
> > > byt_rt5651_cpu_dai_name always fill them with the same string 
> > > (ssp0-port" resp "rt5651-aif2"). So instead of keeping these buffers 
> > > around and making the cpu_dai_name / codec_dai_name point to this, 
> > > simply update the foo_dai_name pointers to directly point to a string 
> > > constant containing the desired string.
> > >
> > > Signed-off-by: Jordy Ubink <jordyubink@xxxxxxxxxx>
> >
> > If you submit a patch, please give your own sign-off as well as the
> > author's one, even if the patch is not written by you. This is a
> > legal requirement.
>
> Sorry, that is my bad, Nariman and the author authors of the patches
> are a group of students doing some kernel work for me and this is
> a warm-up assignment for them to get used to the kernel development
> process.
>
> I forgot to point out to Nariman that since he is sending
> out the entire series for all 4 of them, he needs to add his
> S-o-b.

One suggestion for additional cleanups: can we try and remove all these 
static variables and move them to the context structure? It's been on my 
TODO list for a while.