Re: [PATCH -next] x86: olpc: fix section mismatch warning

From: Rob Herring
Date: Mon May 06 2019 - 17:07:56 EST


+Lubomir

On Mon, May 6, 2019 at 2:31 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix section mismatch warning:
>
> WARNING: vmlinux.o(.text+0x36e00): Section mismatch in reference from the function olpc_dt_compatible_match() to the function .init.text:olpc_dt_getproperty()
> The function olpc_dt_compatible_match() references
> the function __init olpc_dt_getproperty().
> This is often because olpc_dt_compatible_match lacks a __init
> annotation or the annotation of olpc_dt_getproperty is wrong.
>
> All calls to olpc_dt_compatible_match() are from __init functions,
> so it can be marked __init also.
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>

Fixes: a7a9bacb9a32 ("x86/platform/olpc: Use a correct version when
making up a battery node")
Acked-by: Rob Herring <robh@xxxxxxxxxx>