Re: [PATCH 2/8] soundwire: mipi_disco: fix master/link error

From: Pierre-Louis Bossart
Date: Mon May 06 2019 - 21:59:10 EST

On 5/3/19 7:29 PM, Pierre-Louis Bossart wrote:
The MIPI DisCo specification for SoundWire defines the
"mipi-sdw-link-N-subproperties", not the master-N properties. Fix to
parse firmware information.

Please ignore this patch for now, there is a confusion in the spec itself that needs to be addressed by MIPI... Either there will be an errata issued, or we'll have to try both master- and link-N-properties to reconcile spec and actual implementations.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
drivers/soundwire/mipi_disco.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/mipi_disco.c b/drivers/soundwire/mipi_disco.c
index c1f51d6a23d2..6df68584c963 100644
--- a/drivers/soundwire/mipi_disco.c
+++ b/drivers/soundwire/mipi_disco.c
@@ -40,7 +40,7 @@ int sdw_master_read_prop(struct sdw_bus *bus)
/* Find master handle */
snprintf(name, sizeof(name),
- "mipi-sdw-master-%d-subproperties", bus->link_id);
+ "mipi-sdw-link-%d-subproperties", bus->link_id);
link = device_get_named_child_node(bus->dev, name);
if (!link) {