Re: [PATCH AUTOSEL 4.14 79/95] x86/asm: Remove dead __GNUC__ conditionals

From: Greg KH
Date: Tue May 07 2019 - 02:16:04 EST


On Tue, May 07, 2019 at 07:57:01AM +0200, Rasmus Villemoes wrote:
> On 07/05/2019 07.38, Sasha Levin wrote:
> > From: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> >
> > [ Upstream commit 88ca66d8540ca26119b1428cddb96b37925bdf01 ]
> >
> > The minimum supported gcc version is >= 4.6, so these can be removed.
>
> Eh, that bump happened for the 4.19 kernel, so this is not true for the
> 4.14 branch. Has cafa0010cd51fb711fdcb50fc55f394c5f167a0a been applied
> to 4.14.y? Otherwise I don't think this is appropriate.

No, that commit is not in 4.14, so we still have to "support" older
versions of gcc there :(

Sasha, can you drop this?

thanks,

greg k-h