Re: [PATCH 09/15] nds32: switch to generic version of pte allocation

From: Greentime Hu
Date: Tue May 07 2019 - 02:50:33 EST

Hi Mike,

Mike Rapoport <rppt@xxxxxxxxxxxxx> æ 2019å5æ2æ éå äå11:30åéï
> The nds32 implementation of pte_alloc_one_kernel() differs from the generic
> in the use of __GFP_RETRY_MAYFAIL flag, which is removed after the
> conversion.
> The nds32 version of pte_alloc_one() missed the call to pgtable_page_ctor()
> and also used __GFP_RETRY_MAYFAIL. Switching it to use generic
> __pte_alloc_one() for the PTE page allocation ensures that page table
> constructor is run and the user page tables are allocated with
> The conversion to the generic version of pte_free_kernel() removes the NULL
> check for pte.
> The pte_free() version on nds32 is identical to the generic one and can be
> simply dropped.
> Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> ---
> arch/nds32/include/asm/pgalloc.h | 31 ++++---------------------------
> 1 file changed, 4 insertions(+), 27 deletions(-)

Thanks for your patch.
I'm assuming this is going in along with the rest of the patches, so I'm not
going to add it to my tree.

Acked-by: Greentime Hu <greentime@xxxxxxxxxxxxx>