Re: [PATCH] vfio-pci/nvlink2: Fix potential VMA leak

[Greg Kurz]

On Tue, 7 May 2019 11:52:44 +1000
Sam Bobroff <sbobroff@xxxxxxxxxxxxx> wrote:

> On Mon, May 06, 2019 at 03:58:45PM -0600, Alex Williamson wrote:
> > On Fri, 19 Apr 2019 17:37:17 +0200
> > Greg Kurz <groug@xxxxxxxx> wrote:
> >   
> > > If vfio_pci_register_dev_region() fails then we should rollback
> > > previous changes, ie. unmap the ATSD registers.
> > > 
> > > Signed-off-by: Greg Kurz <groug@xxxxxxxx>
> > > ---  
> > 
> > Applied to vfio next branch for v5.2 with Alexey's R-b.  Thanks!
> > 
> > Alex  
> 
> Should this have a fixes tag? e.g.:
> Fixes: 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver")
> 

Oops... you're right.

Alex, can you add the above tag ?

> > >  drivers/vfio/pci/vfio_pci_nvlink2.c |    2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c
> > > index 32f695ffe128..50fe3c4f7feb 100644
> > > --- a/drivers/vfio/pci/vfio_pci_nvlink2.c
> > > +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c
> > > @@ -472,6 +472,8 @@ int vfio_pci_ibm_npu2_init(struct vfio_pci_device *vdev)
> > >  	return 0;
> > >  
> > >  free_exit:
> > > +	if (data->base)
> > > +		memunmap(data->base);
> > >  	kfree(data);
> > >  
> > >  	return ret;
> > >   
> >

Attachment: pgpFmb5XJ7gk2.pgp
Description: OpenPGP digital signature