Re: [PATCH V5 13/16] arm64: tegra: Enable PCIe slots in P2972-0000 board

[Vidya Sagar]

On 5/3/2019 4:57 PM, Thierry Reding wrote:
> On Wed, Apr 24, 2019 at 10:50:01AM +0530, Vidya Sagar wrote:
> > Enable PCIe controller nodes to enable respective PCIe slots on
> > P2972-0000 board. Following is the ownership of slots by different
> > PCIe controllers.
> > Controller-0 : M.2 Key-M slot
> > Controller-1 : On-board Marvell eSATA controller
> > Controller-3 : M.2 Key-E slot
> >
> > Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
> > ---
> > Changes since [v4]:
> > * None
> >
> > Changes since [v3]:
> > * None
> >
> > Changes since [v2]:
> > * Changed P2U label names to reflect new format that includes 'hsio'/'nvhs'
> >    strings to reflect UPHY brick they belong to
> >
> > Changes since [v1]:
> > * Dropped 'pcie-' from phy-names property strings
> >
> >   .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi |  2 +-
> >   .../boot/dts/nvidia/tegra194-p2972-0000.dts   | 41 +++++++++++++++++++
> >   2 files changed, 42 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> > index 0fd5bd29fbf9..30a83d4c5b69 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> > @@ -191,7 +191,7 @@
> >   						regulator-boot-on;
> >   					};
> >   
> > -					sd3 {
> > +					vdd_1v8ao: sd3 {
> >   						regulator-name = "VDD_1V8AO";
> >   						regulator-min-microvolt = <1800000>;
> >   						regulator-max-microvolt = <1800000>;
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> > index b62e96945846..7411c64e24a6 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> > +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> > @@ -169,4 +169,45 @@
> >   			};
> >   		};
> >   	};
> > +
> > +	pcie@14180000 {
> [...]
> > +	pcie@14100000 {
> [...]
>
> Again, these should be sorted by unit-address.
Done.

> Thierry