Re: linux-5.1/drivers/thermal/qcom/tsens-v2.c:54]: bad assignment ?

[Amit Kucheria]

On Tue, May 7, 2019 at 3:40 PM David Binderman <dcb314@xxxxxxxxxxx> wrote:
>
> Hello there,
>
>
> linux-5.1/drivers/thermal/qcom/tsens-v2.c:54]: (style) Assignment 'last_temp=last_temp2' is redundant with condition 'last_temp==last_temp2'.
>
> Source code is
>
>
>         if (last_temp == last_temp2)
>                 last_temp = last_temp2;
>
> Suggest code rework.
>
> Regards
>
> David Binderman

Hi David,

Thanks for the report. That was an old version of the function from
downstream. I've now refactored it and resubmitted it here:

https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1922871.html

Regards,
Amit