Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary

[Daniel Thompson]

On Mon, May 06, 2019 at 11:28:17PM +0900, Masahiro Yamada wrote:
> This patch is technically super easy,
> but shows how difficult to apply a
> single patch in a correct manner.
> 
> 
> The following showed up in today's linux-next,
> doubling
> "Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>"
> 
> This is obviously caused by the committer.

Quite so. Thanks for pointing it out.


> Do we need some check script for maintainers
> before "git push" ?

I have to admit that I think this was just a checkpatch mistake on
my part.

This thread is a bit unusual in that patchwork has collected up
all the example Tested-by: Fred stuff that arose during the earlier
tools conversation. It looks like I was sufficiently distracted by
those to overlook the duplicated sign off...


Daniel.

 
> commit 51fee3389d71bfd281df02c55546a6103779e145
> Author:     Douglas Anderson <dianders@xxxxxxxxxxxx>
> AuthorDate: Fri Mar 22 18:52:27 2019 -0700
> Commit:     Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> CommitDate: Thu May 2 14:55:07 2019 +0100
> 
>     kdb: Get rid of broken attempt to print CCVERSION in kdb summary
> 
>     If you drop into kdb and type "summary", it prints out a line that
>     says this:
> 
>       ccversion  CCVERSION
> 
>     ...and I don't mean that it actually prints out the version of the C
>     compiler.  It literally prints out the string "CCVERSION".
> 
>     The version of the C Compiler is already printed at boot up and it
>     doesn't seem useful to replicate this in kdb.  Let's just delete it.
>     We can also delete the bit of the Makefile that called the C compiler
>     in an attempt to pass this into kdb.  This will remove one extra call
>     to the C compiler at Makefile parse time and (very slightly) speed up
>     builds.
> 
>     Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>     Reviewed-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>     Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>     Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> 
> 
> 
> 
> 
> 
> 
> 
> On Sat, Apr 20, 2019 at 3:24 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> >
> > On Fri, 2019-04-19 at 12:28 +0900, Masahiro Yamada wrote:
> > > Hi Joe,
> > >
> > > Can you detect redundant Cc: by checkpatch?
> > >
> > > Please see below in details.
> > > Thanks.
> >
> > Yes, but I'm not sure why it's useful or necessary.
> > git send-email using some scripts elides duplicate email addresses
> > ---
> >  scripts/checkpatch.pl | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 1c421ac42b07..bedec83cb797 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2688,6 +2688,19 @@ sub process {
> >                                 $signatures{$sig_nospace} = 1;
> >                         }
> >
> > +# Check for a cc: line with another signature -by: by the same author
> > +                       if ($sig_nospace =~ /^cc:/) {
> > +                               my $sig_email = substr($sig_nospace, 3);
> > +                               foreach my $sig (sort keys %signatures) {
> > +                                       next if ($sig =~ /^cc:/);
> > +                                       $sig =~ s/^[^:]+://;
> > +                                       if ($sig eq $sig_email) {
> > +                                               WARN("BAD_SIGN_OFF",
> > +                                                    "Unnecessary CC: as there is another signature with the same name/email address\n" . $herecurr);
> > +                                       }
> > +                               }
> > +                       }
> > +
> >  # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
> >                         if ($sign_off =~ /^co-developed-by:$/i) {
> >                                 if ($email eq $author) {
> >
> >
> 
> 
> -- 
> Best Regards
> Masahiro Yamada