Re: [PATCH v2 08/13] PCI/portdrv: Simplify PCIe feature permission checking
From: Bjorn Helgaas
Date: Tue May 07 2019 - 10:07:56 EST
On Tue, May 07, 2019 at 02:02:34PM +0100, David Woodhouse wrote:
> On Tue, 2019-05-07 at 07:49 -0500, Bjorn Helgaas wrote:
> > No good reason; I just screwed up. Should be fixed in v5.2 (and marked for
> > stable):
> >
> > https://lore.kernel.org/linux-pci/20190318160718.10925-1-jean-philippe.brucker@xxxxxxx
>
> Aha, thanks. And I see 'dwc: Use devm_pci_alloc_host_bridge()' in there
> too, which was the reason we were staring at it in the first place.
>
> That's actually fixing a leak in the error path, not just simplifying
> it, and might want tagging for stable too if it's realistic that
> devm_of_pci_get_host_bridge_resources() would ever actually fail.
OK, IIUC, you're proposing this, where I added the stable tag to "dwc:
Use devm_pci_alloc_host_bridge()":
http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=e6fdd3bf5aec
Lorenzo, just FYI, I cherry-picked remotes/lorenzo/pci/dwc to a pci/dwc
branch to add that tag.
Bjorn