Re: [PATCH 1/5] clk: ingenic: Add missing header in cgu.h

[Stephen Boyd]

Quoting Paul Cercueil (2019-05-07 12:34:17)
> The cgu.h has structures that contain 'clk_onecell_data' and 'clk_hw'
> structures (no pointers), so the <linux/clk-provider.h> header should be
> included.
> 
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> ---
>  drivers/clk/ingenic/cgu.h         | 1 +
>  drivers/clk/ingenic/jz4725b-cgu.c | 1 -
>  drivers/clk/ingenic/jz4740-cgu.c  | 1 -
>  drivers/clk/ingenic/jz4770-cgu.c  | 1 -
>  drivers/clk/ingenic/jz4780-cgu.c  | 1 -
>  5 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/ingenic/cgu.h b/drivers/clk/ingenic/cgu.h
> index e12716d8ce3c..c18198ba2955 100644
> --- a/drivers/clk/ingenic/cgu.h
> +++ b/drivers/clk/ingenic/cgu.h
> @@ -19,6 +19,7 @@
>  #define __DRIVERS_CLK_INGENIC_CGU_H__
>  
>  #include <linux/bitops.h>
> +#include <linux/clk-provider.h>
>  #include <linux/of.h>
>  #include <linux/spinlock.h>
>  
> diff --git a/drivers/clk/ingenic/jz4725b-cgu.c b/drivers/clk/ingenic/jz4725b-cgu.c
> index 584ff4ff81c7..044bbd271bb6 100644
> --- a/drivers/clk/ingenic/jz4725b-cgu.c
> +++ b/drivers/clk/ingenic/jz4725b-cgu.c
> @@ -6,7 +6,6 @@
>   * Author: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
>   */
>  
> -#include <linux/clk-provider.h>

Please leave these here. We want to keep around explicit includes so we
don't get implicit include problems like we just experienced with io.h
not being included in various clk drivers because clk-provider.h did it
for them.