Re: [PATCH] Input: libps2 - mark expected switch fall-through

From: Gustavo A. R. Silva
Date: Tue May 07 2019 - 17:38:26 EST




On 5/7/19 2:27 PM, Dmitry Torokhov wrote:
> On Tue, May 07, 2019 at 01:24:09PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/input/serio/libps2.c: In function âps2_handle_ackâ:
>> drivers/input/serio/libps2.c:407:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (ps2dev->flags & PS2_FLAG_NAK) {
>> ^
>> drivers/input/serio/libps2.c:417:2: note: here
>> case 0x00:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Applied, thank you.
>

Awesome. :)

Thanks, Dmitry.
--
Gustavo