Re: [PATCH] powerpc: restore current_thread_info()
From: Michael Ellerman
Date: Tue May 07 2019 - 20:43:38 EST
Yury Norov <yury.norov@xxxxxxxxx> writes:
> On Tue, May 07, 2019 at 11:58:56PM +0100, Al Viro wrote:
>> On Tue, May 07, 2019 at 03:51:21PM -0700, Yury Norov wrote:
>> > Commit ed1cd6deb013 ("powerpc: Activate CONFIG_THREAD_INFO_IN_TASK")
>> > removes the function current_thread_info(). It's wrong because the
>> > function is used in non-arch code and is part of API.
>>
>> In include/linux/thread_info.h:
>>
>> #ifdef CONFIG_THREAD_INFO_IN_TASK
>> /*
>> * For CONFIG_THREAD_INFO_IN_TASK kernels we need <asm/current.h> for the
>> * definition of current, but for !CONFIG_THREAD_INFO_IN_TASK kernels,
>> * including <asm/current.h> can cause a circular dependency on some platforms.
>> */
>> #include <asm/current.h>
>> #define current_thread_info() ((struct thread_info *)current)
>> #endif
>
> Ah, sorry. Then it might be my rebase issue. I was confused because Christophe
> didn't remove the comment to current_thread_info(), so I decided he
> removed it erroneously.
Yeah you're right, that comment should have been removed too.
cheers