Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

[Marek Vasut]

On 5/8/19 4:48 AM, masonccyang@xxxxxxxxxxx wrote:
> Hi Jones,
> 
>> "Lee Jones" <lee.jones@xxxxxxxxxx>
>> 2019/05/07 äå 08:58
>>
>> To
>>
>> "Marek Vasut" <marek.vasut@xxxxxxxxx>,
>>
>> cc
>>
>> "Rob Herring" <robh@xxxxxxxxxx>, "Mason Yang"
>> <masonccyang@xxxxxxxxxxx>, broonie@xxxxxxxxxx, linux-
>> kernel@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx,
>> bbrezillon@xxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, "Geert
>> Uytterhoeven" <geert+renesas@xxxxxxxxx>,
>> sergei.shtylyov@xxxxxxxxxxxxxxxxxx, mark.rutland@xxxxxxx,
>> devicetree@xxxxxxxxxxxxxxx, juliensu@xxxxxxxxxxx, "Simon Horman"
>> <horms@xxxxxxxxxxxx>, zhengxunli@xxxxxxxxxxx
>>
>> Subject
>>
>> Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3
>> RPC-IF MFD bindings
>>
>> On Wed, 24 Apr 2019, Marek Vasut wrote:
>>
>> > On 4/24/19 11:23 PM, Rob Herring wrote:
>> > > On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote:
>> > >> Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD.
>> > >>
>> > >> Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx>
>> > >> ---
>> > >> Â.../devicetree/bindings/mfd/mfd-renesas-rpc.txt  Â| 40 ++++++
>> ++++++++++++++++
>> > >> Â1 file changed, 40 insertions(+)
>> > >> Âcreate mode 100644 Documentation/devicetree/bindings/mfd/mfd-
>> renesas-rpc.txt
>> > >>
>> > >> diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-
>> rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt
>> > >> new file mode 100644
>> > >> index 0000000..668b822
>> > >> --- /dev/null
>> > >> +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt
>> > >> @@ -0,0 +1,40 @@
>> > >> +Renesas R-Car Gen3 RPC-IF MFD Device Tree Bindings
>> > >> +--------------------------------------------------
>> > >
>> > > Looks like a SPI flash controller from the example. What makes it an
>> > > MFD?
>> >
>> > It supports both SPI NOR and HyperFlash (CFI-compliant flash with
>> > different bus interface).
>>
>> Looks like you're registering one OR the other.
>>
>> Why don't you just do this from DT?
>>
>> No reason for this to be an MFD IMHO.
> 
> 
> okay, I will patch it back to SPI mode only.

I don't think that's what Lee meant . The controller supports _both_
modes , hence it would have the same compatible string. You just need to
extract the mode of operation from the DT.

-- 
Best regards,
Marek Vasut