Re: [GIT PULL] spi updates for v5.2

From: Mark Brown
Date: Wed May 08 2019 - 02:29:59 EST


On Tue, May 07, 2019 at 08:08:50AM -0700, Linus Torvalds wrote:
> On Mon, May 6, 2019 at 7:33 AM Mark Brown <broonie@xxxxxxxxxx> wrote:

> > spi: Updates for v5.2

> Hmm. Please be more careful. Commit 1dfbf334f123 ("spi: ep93xx:
> Convert to use CS GPIO descriptors") caused a new warning because it
> removed a "for ()" loop, but left the now unused variable 'i' around.

> I fixed it up in the merge, because I hate warnings that may hide real
> problems. But I also expect maintainers to check their warnings,
> exactly because the normal build is supposed to have none. So a new
> warning does stand out.

Sorry, I've actually got a fix for that queued but obviously didn't
manage to make sure it made it all the way through the process to the
pull request.

Attachment: signature.asc
Description: PGP signature