Re: [PATCH v6] iio: cros_ec: Add lid angle driver

From: Lee Jones
Date: Wed May 08 2019 - 06:49:19 EST


On Wed, 24 Apr 2019, Gwendal Grignou wrote:

> Add a IIO driver that reports the angle between the lid and the base for
> ChromeOS convertible device.
>
> Tested on eve with ToT EC firmware.
> Check driver is loaded and lid angle is correct.
>
> Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> ---
> Changes in v6:
> - Fix lock held in an error path error.
>
> Changes in v5:
> - Remove unnecessary define.
> - v4 was the wrong patch file
>
> Changes in v3:
> - Use static channel array, simplify code because index is always 0.
>
> Changes in v2:
> - Fix license, remove driver_module field.
>
> drivers/iio/common/cros_ec_sensors/Kconfig | 9 ++
> drivers/iio/common/cros_ec_sensors/Makefile | 1 +
> .../cros_ec_sensors/cros_ec_lid_angle.c | 139 ++++++++++++++++++

> drivers/mfd/cros_ec_dev.c | 13 +-

Since there aren't any built-time dependencies between them, this
change should be pulled out into a separate patch, which will go in
via the MFD tree.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog