Re: [PATCH] of: Add dummy for of_node_is_root if not CONFIG_OF

From: Doug Anderson
Date: Wed May 08 2019 - 11:52:26 EST


Hi,

On Tue, May 7, 2019 at 3:17 PM Frank Rowand <frowand.list@xxxxxxxxx> wrote:
>
> On 5/7/19 10:59 AM, Doug Anderson wrote:
> > Hi,
> >
> >
> > On Tue, May 7, 2019 at 10:52 AM Frank Rowand <frowand.list@xxxxxxxxx> wrote:
> >>
> >> On 5/6/19 9:48 PM, Douglas Anderson wrote:
> >>> We'll add a dummy to just return false.
> >>
> >> A more complete explanation of why this is needed please.
> >>
> >> My one guess would be compile testing of arch/sparc/kernel/prom_64.c
> >> fails???
> >
> > Ah, sorry. Needed for:
> >
> > https://lkml.kernel.org/r/CAD=FV=Vxp-U7mZUNmAAOja5pt-8rZqPryEvwTg_Dv3ChuH_TrA@xxxxxxxxxxxxxx
>
> Got it. I went and looked at that. I think a better approach would be to
> check parent node not "/reserved-memory". I am making this suggestion in
> that email thread.

OK. Assuming that people are happy with that approach [1], we should
consider this patch abandoned. Thanks for your reviews!

[1] https://lkml.kernel.org/r/20190508154832.241525-1-dianders@xxxxxxxxxxxx

-Doug