Re: [PATCH 16/22] perf/x86/intel/uncore: Support multi-die/package

From: Len Brown
Date: Wed May 08 2019 - 15:53:05 EST


On Tue, May 7, 2019 at 8:22 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Mon, May 06, 2019 at 05:26:11PM -0400, Len Brown wrote:
> > @@ -1223,7 +1225,7 @@ static int uncore_event_cpu_online(unsigned int cpu)
> > struct intel_uncore_box *box;
> > int i, ret, pkg, target;
> >
> > - pkg = topology_logical_package_id(cpu);
> > + pkg = topology_logical_die_id(cpu);
> > ret = allocate_boxes(types, pkg, cpu);
> > if (ret)
> > return ret;
>
> 'pkg' != 'die'

To keep the patch with this functional change minimal and obvious,
the rename of this variable was segregated into patch 22, which is
re-names only.

Len Brown, Intel Open Source Technology Center