Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

[Robert R. Howell]

On 4/30/19 8:39 AM, Hans de Goede wrote:
> 
> Hi,
> 
> On 4/25/19 6:38 PM, Robert R. Howell wrote:
>> On 4/24/19 1:20 AM, Rafael J. Wysocki wrote:
>>
>>> On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howell <RHowell@xxxxxxxx> wrote:
>>>>
>>>> On 4/23/19 2:07 AM, Rafael J. Wysocki wrote:
>>>>>
>>>>> On Sat, Apr 20, 2019 at 12:44 AM Robert R. Howell <RHowell@xxxxxxxx> wrote:
>>>>>>
>>>>>> On 4/18/19 5:42 AM, Hans de Goede wrote:
>>>>>>
>>>>>>>> On 4/8/19 2:16 AM, Hans de Goede wrote:>
>>>>>>>>>
>>>>>>>>> Hmm, interesting so you have hibernation working on a T100TA
>>>>>>>>> (with 5.0 + 02e45646d53b reverted), right ?
>>>>>>>>>
>>>>>>
>>>>>>
>>>>>> I've managed to find a way around the i2c_designware timeout issues
>>>>>> on the T100TA's. The key is to NOT set DPM_FLAG_SMART_SUSPEND,
>>>>>> which was added in the 02e45646d53b commit.
>>>>>>
>>>>>> To test that I've started with a 5.1-rc5 kernel, applied your recent patch
>>>>>> to acpi_lpss.c, then apply the following patch of mine, removing
>>>>>> DPM_FLAG_SMART_SUSPEND. (For the T100 hardware I need to apply some
>>>>>> other patches as well but those are not related to the i2c-designware or
>>>>>> acpi issues addressed here.)
>>>>>>
>>>>>> On a resume from hibernation I still see one error:
>>>>>> ÂÂ "i2c_designware 80860F41:00: Error i2c_dw_xfer called while suspended"
>>>>>> but I no longer get the i2c_designware timeouts, and audio does now work
>>>>>> after the resume.
>>>>>>
>>>>>> Removing DPM_FLAG_SMART_SUSPEND may not be what you want for other
>>>>>> hardware, but perhaps this will give you a clue as to what is going
>>>>>> wrong with hibernate/resume on the T100TA's.
>>>>>
>>>>> What if you drop DPM_FLAG_LEAVE_SUSPENDED alone instead?
>>>>>
>>>>
>>>> I did try dropping just DPM_FLAG_LEAVE_SUSPENDED, dropping just
>>>> DPM_FLAG_SMART_SUSPEND, and dropping both flags. When I just drop
>>>> DPM_FLAG_LEAVE_SUSPENDED I still get the i2c_designware timeouts
>>>> after the resume. If I drop just DPM_FLAG_SMART_SUSPEND or drop both,
>>>> then the timeouts go away.
>>>
>>> OK, thanks!
>>>
>>> Is non-hibernation system suspend affected too?
>>
>> I just ran some tests on a T100TA, using the 5.1-rc5 code with Hans' patch applied
>> but without any changes to i2c-designware-platdrv.c, so the
>> DPM_FLAG_SMART_PREPARE, DPM_FLAG_SMART_SUSPEND, and DPM_FLAG_LEAVE_SUSPENDED flags
>> are all set.
>>
>> Suspend does work OK, and after resume I do NOT get any of the crippling
>> i2c_designware timeout errors which cause sound to fail after hibernate. I DO see one
>> ÂÂ "i2c_designware 80860F41:00: Error i2c_dw_xfer call while suspended"
>> error on resume, just as I do on hibernate. I've attached a portion of dmesg below.
>> The "asus_wmi:Â Unknown key 79 pressed" error is a glitch which occurs
>> intermittently on these machines, but doesn't seem related to the other issues.
>> I had one test run when it was absent but the rest of the messages were the
>> same -- but then kept getting that unknown key error on all my later tries.
> 
> I've just tried to reproduce the "Error i2c_dw_xfer call while suspended" error
> on suspend/resume on my own T100TA and I could not reproduce this.
> 
> Can you try without the BT keyboard paired and waking up from suspend using the
> tablet part's power-button ?
> 
> Also do you still have the scripts to rmmod some modules before suspend ?
> 

The T100TA keyboard is actually a hardwired connection rather than Bluetooth but I
did physically disconnect the keyboard, and also unpaired all the actual Bluetooth 
devices (such as the mouse) and then powered down the T100TA bluetooth adapter. 
When I suspend, then resume using the tablet power button, I still get the 
i2c_dw_xfererror error during the resume.  But whatever causes this error isn't fatal, 
in the sense that after resume the sound and other i2c functions do still work OK.

While I always get this i2c_dw_xfer error on resume from suspend or hibernation on the T100TA, 
I also have a T100TAM and curiously, it NEVER shows that error -- although all the 
other suspend and hibernate behavior seems similar.  I'm not sure if the following could 
be the difference, but the T100TA uses an i2c connected ATML1000 touchscreen controller 
while the T100TAM uses an i2c connected SIS0817 touchscreen controller.  Other than that 
the hardware seems almost identical.

Regarding scripts, while I do still need a systemd hibernate script which removes the 
brcmfmac and the hci_uart (bluetooth related) drivers, I've found that I no longer need 
any script for suspend.

>> I did notice the "2sidle" in the following rather than "shallow" or "deep". A
>> cat of /sys/power/state shows "freeze mem disk" but a
>> cat of /sys/power/mem_sleep" shows only "[s2idle] so it looks like shallow and deep
>> are not enabled for this system. I did check the input power (or really current)
>> as it went into suspend and the micro-usb power input drops from about
>> 0.5 amps to 0.05 amps. But clearly a lot of devices are still active, as movement
>> of a bluetooth mouse (the MX Anywhere 2) will wake it from suspend. That presumably is
>> why suspend doesn't trigger the same i2c_designware problems as hibernate.
> 
> s2idle is the normal / expected suspend condition on these tablet devices.
> 
> As for how much energy is consumed during suspend, the device should use
> S0i3 and then you should get ok (so not great, but also not too much) power
> consumption during suspend:
> 
> [root@dhcp-43-189 ~]# cat /sys/kernel/debug/pmc_atom/sleep_state
> S0IR Residency: 156256us
> S0I1 Residency: 3968us
> S0I2 Residency: 0us
> S0I3 Residency: 70557440us
> S0ÂÂ Residency: 11826052384us
> 
> After being suspended for a couple of seconds, you should see a significant
> (large) value in S0I3 like above.

Thanks for this information on the suspend mode.  I DO see the S0I3 Residency grow 
after a suspend.

Sorry for the long response time -- I was out of town most of last week.

Let me know if I can run any more tests.

Bob

> 
> Regards,
> 
> Hans
> 
> 
> 
> 
> 
> 
>>
>> Let me know if I can do any other tests.
>>
>> Bob Howell
>>
>> ----DMESG OUTPUT ON SUSPEND------------------
>> [ÂÂ 71.791495] NET: Registered protocol family 38
>> [ÂÂ 73.150736] input: MX Anywhere 2 Keyboard as /devices/virtual/misc/uhid/0005:046D:B013.0005/input/input24
>> [ÂÂ 73.156612] input: MX Anywhere 2 Mouse as /devices/virtual/misc/uhid/0005:046D:B013.0005/input/input25
>> [ÂÂ 73.159504] hid-generic 0005:046D:B013.0005: input,hidraw4: BLUETOOTH HID v0.07 Keyboard [MX Anywhere 2] on 74:D0:2B:DF:77:E9
>> [Â 102.719170] asus_wmi: Unknown key 79 pressed
>> [Â 102.897214] asus_wmi: Unknown key 79 pressed
>> [Â 104.298409] PM: suspend entry (s2idle)
>> [Â 104.298414] PM: Syncing filesystems ... done.
>> [Â 105.410883] Freezing user space processes ... (elapsed 0.002 seconds) done.
>> [Â 105.413556] OOM killer disabled.
>> [Â 105.413558] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
>> [Â 123.353720] i2c_designware 80860F41:00: Error i2c_dw_xfer call while suspended
>> [Â 123.635028] ACPI: button: The lid device is not compliant to SW_LID.
>> [Â 124.086421] OOM killer enabled.
>> [Â 124.086491] Restarting tasks ... done.
>> [Â 124.120647] PM: suspend exit
>> [Â 124.939566] asus_wmi: Unknown key 79 pressed
>>