Re: [PATCH 02/25] tracing: Improve "if" macro code generation

From: Steven Rostedt
Date: Thu May 09 2019 - 15:08:03 EST


On Thu, 9 May 2019 13:45:31 -0500
Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> Actually, my original fix already went in:
>
> 37686b1353cf ("tracing: Improve "if" macro code generation")
>
> But it introduced a regression:
>
> https://lkml.kernel.org/r/201905040509.iqQ2CrOU%lkp@xxxxxxxxx
>
> which Linus' patch fixes for some reason.

Hmm, I'm still working on my pull request for the merge window, and if
this already went in, I could just add this, and let it conflict. I'm
sure Linus will have no problems in fixing up the conflicts.

I should change the subject, as it is the same ;-) Perhaps to:

tracing: Clean up "if" macro

But it would be good to find out why this fixes the issue you see.
Perhaps its because we remove the internal if statement?

-- Steve