Re: [RESEND PATCH v5 0/3] Add PM support to STM32 LP Timer drivers

From: Fabrice Gasnier
Date: Fri May 10 2019 - 03:52:40 EST


On 4/18/19 11:37 AM, Fabrice Gasnier wrote:
> This patch series adds power management support for STM32 LP Timer:
> - PWM driver
> - Document the pinctrl states for sleep mode
>
> It also adds device link between the PWM consumer and the PWM provider.
> This allows proper sequencing for suspend/resume (e.g. user will likely
> do a pwm_disable() before the PWM provider suspend executes), see [1].
>
> [1] https://lkml.org/lkml/2019/2/5/770
>

Hi Thierry,

Please let me know if you have some more comments on this series. It's
been under review since quite some time now.

Thanks in advance,
Best Regards,
Fabrice

> ---
> resend v5:
> - update collected acks
>
> Changes in v5:
> - improve a warning message, fix a style issue.
>
> Changes in v4:
> - improve error handling when adding the PWM consumer device link.
>
> Changes in v3:
> - Move the device_link_add() call to of_pwm_get() as discussed with Uwe.
>
> Changes in v2:
> - Don't disable PWM channel in PWM provider: rather refuse to suspend
> and report an error as suggested by Uwe and Thierry.
> - Add patch 3/3 to propose device link addition.
> - No updates for STM32 LP Timer IIO driver. Patches can be send separately.
>
> Fabrice Gasnier (3):
> dt-bindings: pwm-stm32-lp: document pinctrl sleep state
> pwm: stm32-lp: Add power management support
> pwm: core: add consumer device link
>
> .../devicetree/bindings/pwm/pwm-stm32-lp.txt | 9 ++--
> drivers/pwm/core.c | 50 ++++++++++++++++++++--
> drivers/pwm/pwm-stm32-lp.c | 25 +++++++++++
> include/linux/pwm.h | 6 ++-
> 4 files changed, 82 insertions(+), 8 deletions(-)
>