Re: [PATCH v2 06/17] kbuild: enable building KUnit

From: Masahiro Yamada
Date: Fri May 10 2019 - 06:32:37 EST


On Fri, May 10, 2019 at 7:27 PM Brendan Higgins
<brendanhiggins@xxxxxxxxxx> wrote:
>
> > On Thu, May 2, 2019 at 8:03 AM Brendan Higgins
> > <brendanhiggins@xxxxxxxxxx> wrote:
> > >
> > > Add KUnit to root Kconfig and Makefile allowing it to actually be built.
> > >
> > > Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
> >
> > You need to make sure
> > to not break git-bisect'abililty.
> >
> >
> > With this commit, I see build error.
> >
> > CC kunit/test.o
> > kunit/test.c:11:10: fatal error: os.h: No such file or directory
> > #include <os.h>
> > ^~~~~~
> > compilation terminated.
> > make[1]: *** [scripts/Makefile.build;279: kunit/test.o] Error 1
> > make: *** [Makefile;1763: kunit/] Error 2
>
> Nice catch! That header shouldn't even be in there.
>
> Sorry about that. I will have it fixed in the next revision.


BTW, I applied whole of this series
to my kernel.org repository.

0day bot started to report issues.
I hope several reports reached you,
and they are useful to fix your code.


--
Best Regards
Masahiro Yamada