Re: [PATCH v3 2/2] dt-bindings: power: reset: add document for NVMEM based reboot-mode

[Nandor Han]

On 5/1/19 1:47 AM, Rob Herring wrote:

Hi Rob,
  Thanks for review.

> > @@ -0,0 +1,32 @@
> > +NVMEM reboot mode driver
> > +
> > +This driver gets reboot mode magic value from reboot-mode driver
> > +and stores it in a NVMEM cell named "reboot-mode". Then the bootloader
> > +can read it and take different action according to the magic
> > +value stored.
>
> This is also assuming the nvmem is writeable which is more often not the
> case.
>
> Is your usecase a platform that supports pstore? Adding on to that
> binding might be a better fit.

I'm using an RTC persistent memory for storing this data. The available
memory is low and don't think pstore will fit in this case.

> > +The rest of the properties should follow the generic reboot-mode description
> > +found in reboot-mode.txt
> > +
> > +Example:
> > +	reboot-mode-nvmem@0 {
>
> What's this node for?
>
> > +		compatible = "simple-mfd";
>
> I only see 1 function.

No need to this. Will remove

Nandor