Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

[Takashi Iwai]

On Fri, 10 May 2019 15:34:03 +0200,
Pierre-Louis Bossart wrote:
> 
> On 5/10/19 8:04 AM, Takashi Iwai wrote:
> > On Fri, 10 May 2019 14:56:29 +0200,
> > Pierre-Louis Bossart wrote:
> >>
> >> On 5/10/19 2:12 AM, Takashi Iwai wrote:
> >>> On Fri, 10 May 2019 04:36:57 +0200,
> >>> YueHaibing wrote:
> >>>>
> >>>> Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m
> >>>>
> >>>> sound/soc/sof/core.o: In function `snd_sof_device_probe':
> >>>> core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup'
> >>>>
> >>>> Change SND_SOC_SOF_NOCODEC to bool to fix this.
> >>>>
> >>>> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> >>>> Fixes: c16211d6226d ("ASoC: SOF: Add Sound Open Firmware driver core")
> >>>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> >>>
> >>> This change would break things severely.  This won't allow to build it
> >>> as a module any longer.
> >>
> >> Isn't this fixed already?
> >> See the patch  'ASoC: SOF: core: fix undefined nocodec reference' and
> >> Takashi's follow-up to fix the unused variable warning.
> >
> > Possibly the problem still persists although I haven't seen through my
> > local build tests with randconfig.  You can set SND_SOC_SOF=y and
> > SND_SOC_NOCODEC=m, i.e. built-in sof-core while nocodec is a module.
> 
> YueHiabing, can you share the config and SHA1 so that we can double check?
> 
> If the problem persists, we can do something like
> 
> config SND_SOF_NOCODEC_SUPPORT
> 	bool "SOF nocodec mode support"
> 
> config SND_SOF_NOCODEC
> 	tristate
> 
> confir SND_SOC_SOF
> 	tristate
> 	select SND_SOF_NOCODEC if SND_SOF_NOCODEC_SUPPORT
> 
> that way you propagate the required dependencies

Yes, that would work.  OTOH, I see no merit to build an extra module
for nocodec.  nocodec.c can be built together with sof-core stuff.


thanks,

Takashi