Re: [PATCH] spi: TI power management: add missing of table registration

From: Daniel G
Date: Sat May 11 2019 - 04:29:59 EST


On Wed, May 8, 2019 at 12:27 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> The subject line is not correct. This is an MFD driver.
>
> When submitting you should follow the convention for the subsystem you
> are patching against. The following command is helpful:
>
> `git log --oneline -- <SUBSYSTEM>`
>
> I will fix it for you this time (and for the other patch I see).
>
Sorry for that and thanks for rewriting the subject.

> On Mon, 22 Apr 2019, Daniel Gomez wrote:
>
> > MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> > OF mathing mechanism and register it.
> >
> > Before this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias: spi:tps65912
> >
> > After this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias: of:N*T*Cti,tps65912C*
> > alias: of:N*T*Cti,tps65912
> > alias: spi:tps65912
> >
> > Reported-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
> > Signed-off-by: Daniel Gomez <dagmcr@xxxxxxxxx>
> > ---
> > drivers/mfd/tps65912-spi.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Applied, thanks.
>
> --
> Lee Jones [æçæ]
> Linaro Services Technical Lead
> Linaro.org â Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog