Re: [PATCH] kbuild: terminate Kconfig when $(CC) or $(LD) is missing

[Masahiro Yamada]

On Mon, May 13, 2019 at 11:35 AM Joel Stanley <joel@xxxxxxxxx> wrote:
>
> On Mon, 13 May 2019 at 02:28, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> >
> > On Thu, May 9, 2019 at 4:36 PM Masahiro Yamada
> > <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> > >
> > > If the compiler specified by $(CC) is not present, the Kconfig stage
> > > sprinkles 'not found' messages, then succeeds.
> > >
> > >   $ make CROSS_COMPILE=foo defconfig
> > >   /bin/sh: 1: foogcc: not found
> > >   /bin/sh: 1: foogcc: not found
> > >   *** Default configuration is based on 'x86_64_defconfig'
> > >   ./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found
> > >   ./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found
> > >   ./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found
> > >   ./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found
> > >   ./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found
> > >   ./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found
> > >   ./scripts/clang-version.sh: 11: ./scripts/clang-version.sh: foogcc: not found
> > >   ./scripts/gcc-plugin.sh: 11: ./scripts/gcc-plugin.sh: foogcc: not found
> > >   init/Kconfig:16:warning: 'GCC_VERSION': number is invalid
> > >   #
> > >   # configuration written to .config
> > >   #
> > >
> > > Terminate parsing files immediately if $(CC) or $(LD) is not found.
> > > "make *config" will fail more nicely.
> > >
> > >   $ make CROSS_COMPILE=foo defconfig
> > >   *** Default configuration is based on 'x86_64_defconfig'
> > >   scripts/Kconfig.include:34: compiler 'foogcc' not found
> > >   make[1]: *** [scripts/kconfig/Makefile;82: defconfig] Error 1
> > >   make: *** [Makefile;557: defconfig] Error 2
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > > ---
> >
> > Applied to linux-kbuild.
>
> Thanks Masahiro! I had this in my inbox to test but you're too efficient.
>
> Testing your patch on linus' tree as of today (d7a02fa0a8f9) gives me
> this output:
>
> $ CROSS_COMPILE=foo  make
> make: foogcc: Command not found
> scripts/kconfig/conf  --syncconfig Kconfig
> scripts/Kconfig.include:34: compiler 'foogcc' not found
> make[2]: *** [scripts/kconfig/Makefile:69: syncconfig] Error 1
> make[1]: *** [Makefile:557: syncconfig] Error 2
> make: *** [include/config/auto.conf.cmd] Deleting file
> 'include/config/tristate.conf'
> make: Failed to remake makefile 'include/config/auto.conf'.
>   SYSTBL  arch/x86/include/generated/asm/syscalls_32.h
>   SYSHDR  arch/x86/include/generated/asm/unistd_32_ia32.h
>   SYSHDR  arch/x86/include/generated/asm/unistd_64_x32.h
>   SYSTBL  arch/x86/include/generated/asm/syscalls_64.h
>   SYSHDR  arch/x86/include/generated/uapi/asm/unistd_32.h
>   SYSHDR  arch/x86/include/generated/uapi/asm/unistd_64.h
>   SYSHDR  arch/x86/include/generated/uapi/asm/unistd_x32.h
>   HOSTCC  arch/x86/tools/relocs_32.o
>   HOSTCC  arch/x86/tools/relocs_64.o
>   HOSTCC  arch/x86/tools/relocs_common.o
>   HOSTLD  arch/x86/tools/relocs
>   UPD     include/config/kernel.release
>   WRAP    arch/x86/include/generated/uapi/asm/bpf_perf_event.h
>   WRAP    arch/x86/include/generated/uapi/asm/poll.h
>   WRAP    arch/x86/include/generated/uapi/asm/socket.h
>   WRAP    arch/x86/include/generated/uapi/asm/sockios.h
>   WRAP    arch/x86/include/generated/asm/dma-contiguous.h
>   WRAP    arch/x86/include/generated/asm/early_ioremap.h
>   WRAP    arch/x86/include/generated/asm/export.h
>   WRAP    arch/x86/include/generated/asm/mcs_spinlock.h
>   WRAP    arch/x86/include/generated/asm/mm-arch-hooks.h
>   WRAP    arch/x86/include/generated/asm/mmiowb.h
>   UPD     include/generated/uapi/linux/version.h
>   UPD     include/generated/utsrelease.h
>   HOSTCC  scripts/selinux/genheaders/genheaders
>   HOSTCC  scripts/selinux/mdp/mdp
>   HOSTCC  scripts/kallsyms
>   HOSTCC  scripts/pnmtologo
>   HOSTCC  scripts/conmakehash
>   HOSTCC  scripts/sortextable
>   HOSTCC  scripts/asn1_compiler
>   HOSTCC  scripts/extract-cert
> You are building kernel with non-retpoline compiler.
> Please update your compiler.
> make: *** [arch/x86/Makefile:308: checkbin] Error 1
>
> Which is a little confusing.
>
> The second time is shorter, but the retpoline message is not ideal:
>
> $ CROSS_COMPILE=foo  make
> make: foogcc: Command not found
> scripts/kconfig/conf  --syncconfig Kconfig
> scripts/Kconfig.include:34: compiler 'foogcc' not found
> make[2]: *** [scripts/kconfig/Makefile:69: syncconfig] Error 1
> make[1]: *** [Makefile:557: syncconfig] Error 2
> make: Failed to remake makefile 'include/config/auto.conf'.
> You are building kernel with non-retpoline compiler.
> Please update your compiler.


I think you are seeing a different bug.

Please test after applying this as well:
https://patchwork.kernel.org/patch/10939845/


Thanks.




-- 
Best Regards
Masahiro Yamada